Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Conversation

harshil07
Copy link

No description provided.

@harshil07 harshil07 mentioned this pull request Mar 5, 2015
@thgreasi
Copy link
Contributor

thgreasi commented Mar 5, 2015

First of all, thanks for the contribution. It's really great to have wide community participation.

I created a pen example that includes jquery-ui before angularjs and seems to work fine.
Can you include an example showcasing your use case that caused the error?

@thgreasi
Copy link
Contributor

thgreasi commented Mar 6, 2015

Oops typo. I meant "angularjs before jquery-ui".

@harshil07
Copy link
Author

Not sure what the best tool is to create an example for this. I currently using requirejs for loading dependencies and also using jqueryui-amd version. If I don't have 'jqueryui' as a dependency for 'angular' in the config.js then I get the previously error mentioned in the issue.

@thgreasi
Copy link
Contributor

What if you just define jquery as a dependency to angular, as shown by the
requirejs example, found in the README.md ?

Please feel free to fork that code example (or any other applicable) for
your demonstration purposes.

On Tue, Mar 10, 2015, 15:49 Harshil Shah notifications@github.com wrote:

Not sure what the best tool is to create an example for this. I currently
using requirejs for loading dependencies and also using jqueryui-amd
version. If I don't have 'jqueryui' as a dependency for 'angular' in the
config.js then I get the previously error mentioned in the issue.


Reply to this email directly or view it on GitHub
#342 (comment)
.

@harshil07
Copy link
Author

I already have jquery as a dependency for angular. doesn't work though.

Best Regards,
Harshil

On Tue, Mar 10, 2015 at 12:34 PM, Thodoris Greasidis <
notifications@github.com> wrote:

What if you just define jquery as a dependency to angular, as shown by the
requirejs example, found in the README.md ?

Please feel free to fork that code example (or any other applicable) for
your demonstration purposes.

On Tue, Mar 10, 2015, 15:49 Harshil Shah notifications@github.com wrote:

Not sure what the best tool is to create an example for this. I currently
using requirejs for loading dependencies and also using jqueryui-amd
version. If I don't have 'jqueryui' as a dependency for 'angular' in the
config.js then I get the previously error mentioned in the issue.


Reply to this email directly or view it on GitHub
<
https://github.com/angular-ui/ui-sortable/pull/342#issuecomment-78055771>

.


Reply to this email directly or view it on GitHub
#342 (comment)
.

@thgreasi
Copy link
Contributor

If you are able to provide a code example to show your case I will be happy
to merge this PR.
But my experience till now does not show what you are reporting.

On Tue, Mar 10, 2015, 18:44 Harshil Shah notifications@github.com wrote:

I already have jquery as a dependency for angular. doesn't work though.

Best Regards,
Harshil

On Tue, Mar 10, 2015 at 12:34 PM, Thodoris Greasidis <
notifications@github.com> wrote:

What if you just define jquery as a dependency to angular, as shown by
the
requirejs example, found in the README.md ?

Please feel free to fork that code example (or any other applicable) for
your demonstration purposes.

On Tue, Mar 10, 2015, 15:49 Harshil Shah notifications@github.com
wrote:

Not sure what the best tool is to create an example for this. I
currently
using requirejs for loading dependencies and also using jqueryui-amd
version. If I don't have 'jqueryui' as a dependency for 'angular' in
the
config.js then I get the previously error mentioned in the issue.


Reply to this email directly or view it on GitHub
<
#342 (comment)

.


Reply to this email directly or view it on GitHub
<
https://github.com/angular-ui/ui-sortable/pull/342#issuecomment-78092308>
.


Reply to this email directly or view it on GitHub
#342 (comment)
.

@harshil07
Copy link
Author

yep. will try and recreate a sample.

Best Regards,
Harshil

On Tue, Mar 10, 2015 at 1:46 PM, Thodoris Greasidis <
notifications@github.com> wrote:

If you are able to provide a code example to show your case I will be happy
to merge this PR.
But my experience till now does not show what you are reporting.

On Tue, Mar 10, 2015, 18:44 Harshil Shah notifications@github.com wrote:

I already have jquery as a dependency for angular. doesn't work though.

Best Regards,
Harshil

On Tue, Mar 10, 2015 at 12:34 PM, Thodoris Greasidis <
notifications@github.com> wrote:

What if you just define jquery as a dependency to angular, as shown by
the
requirejs example, found in the README.md ?

Please feel free to fork that code example (or any other applicable)
for
your demonstration purposes.

On Tue, Mar 10, 2015, 15:49 Harshil Shah notifications@github.com
wrote:

Not sure what the best tool is to create an example for this. I
currently
using requirejs for loading dependencies and also using jqueryui-amd
version. If I don't have 'jqueryui' as a dependency for 'angular' in
the
config.js then I get the previously error mentioned in the issue.


Reply to this email directly or view it on GitHub
<

#342 (comment)

.


Reply to this email directly or view it on GitHub
<
#342 (comment)

.


Reply to this email directly or view it on GitHub
<
https://github.com/angular-ui/ui-sortable/pull/342#issuecomment-78094172>

.


Reply to this email directly or view it on GitHub
#342 (comment)
.

@thgreasi
Copy link
Contributor

@harshil07 I'm closing this for now.
Feel free to reopen with a code example and then we can merge this.

@thgreasi thgreasi closed this Mar 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants